em/slstatus
1
0
Fork 0
Code Releases Activity
379adb0a6a
slstatus/config.mk

23 lines
456 B
Makefile
Raw Normal View History

Refactor build system
2017-08-10 21:32:10 +02:00
# slstatus version
Release stable 1.0 version
2023-07-04 20:47:18 +02:00
VERSION = 1.0
shorter copyright notice and moved back VERSION and _GNU_SOURCE as the man page version number fails
2016-09-18 22:00:50 +02:00
Small fixes in config.mk
2017-12-03 01:40:38 +01:00
# customize below to fit your system
Refactor build system
2017-08-10 21:32:10 +02:00
Small fixes in config.mk
2017-12-03 01:40:38 +01:00
# paths
Revert "config.mk: Fix PREFIX assignment" "?=" is not POSIX, packagers should use "make PREFIX=". This reverts commit c225c4315161a992b9e44dd990d083ee57f7f713.
2022-12-19 19:26:57 +01:00
PREFIX = /usr/local
Tweak build system a little bit Be consistent with brackets and add a comment for OpenBSD to make it clearer what the actual intent of the uncommented line is. In the Makefile, add a dependency of slstatus.o from config.mk.
2018-05-01 20:50:53 +02:00
MANPREFIX = $(PREFIX)/share/man
bringed back the old config.mk
2016-09-05 00:40:47 +02:00
X11INC = /usr/X11R6/include
X11LIB = /usr/X11R6/lib
Refactor build system
2017-08-10 21:32:10 +02:00
# flags
Add back version flag to prepare for release
2023-05-15 19:14:52 +02:00
CPPFLAGS = -I$(X11INC) -D_DEFAULT_SOURCE -DVERSION=\"${VERSION}\"
do not rely on obsolete feature function prototype with unspecified argument is obsolete since c99. additionally some of these function which don't take any argument were being called with a `const char *` arg, which is UB. fix both these issues by declararing ALL the components to accept a `const char *`, and name the arg "unused" if it's meant to be ignored.
2022-10-26 22:16:05 +02:00
CFLAGS = -std=c99 -pedantic -Wall -Wextra -Wno-unused-parameter -Os
Revert component-split this reverts the commits from 92ab9ef52ebcb097add97d9f78e67ad1c1d6a6ec up to d42870d6ca7fb587b38f8cf6d6821ae33a53a696. After heavy consideration, the component split has more disadvantages than advantages, especially given there will be utility-functions sharing quite a lot of code that would then need to be duplicated, as it does not fit into the util.c due to its speciality. One big advantage of the component-wise build is readability, and without doubt, this was achieved here. This point will be addressed with a different approach that will be visible in the upcoming commits. One big disadvantage of the component build is the fact that it introduces state to the build process which is not necessary. Before its introduction, the only influencing factors where the system-defines __linux__ and __OpenBSD__. With the components, we are also relying on the output of uname(1). Additionally, if the os.mk is not present, make gives the output $ make Makefile:5: os.mk: No such file or directory make: *** No rule to make target 'os.mk'. Stop. This could easily be fixed by providing some sort of meta-rule for this file, however, it indicates the problem we have here, and this entire statefulness will heavily complicate packaging of this tool and makes the build process much more complex than it actually has to be.
2018-05-01 18:10:39 +02:00
LDFLAGS = -L$(X11LIB) -s
Use the sioctl_open(3) OpenBSD API to access vol Starting with OpenBSD 6.7 regular users cannot access raw audio devices anymore, for improved security. Instead use the sioctl_open(3) API to access and manipulate audio controls exposed by sndiod(8). On the first call a permanent connection is established with the running sndiod daemon, and call-back functions are registered which are triggered when audio controls are changed (e.g., a USB headset is attached) or when the volume is modified. On subsequent calls we poll for changes; if there are no volume changes this costs virtually nothing. Joint work with Alexandre Ratchov
2020-05-09 12:03:20 +02:00
# OpenBSD: add -lsndio
Make volume component work on FreeBSD - Edit compile instructions - Reuse OpenBSD sndio implementation
2021-01-01 16:52:57 +01:00
# FreeBSD: add -lkvm -lsndio
Tweak build system a little bit Be consistent with brackets and add a comment for OpenBSD to make it clearer what the actual intent of the uncommented line is. In the Makefile, add a dependency of slstatus.o from config.mk.
2018-05-01 20:50:53 +02:00
LDLIBS = -lX11
Revert component-split this reverts the commits from 92ab9ef52ebcb097add97d9f78e67ad1c1d6a6ec up to d42870d6ca7fb587b38f8cf6d6821ae33a53a696. After heavy consideration, the component split has more disadvantages than advantages, especially given there will be utility-functions sharing quite a lot of code that would then need to be duplicated, as it does not fit into the util.c due to its speciality. One big advantage of the component-wise build is readability, and without doubt, this was achieved here. This point will be addressed with a different approach that will be visible in the upcoming commits. One big disadvantage of the component build is the fact that it introduces state to the build process which is not necessary. Before its introduction, the only influencing factors where the system-defines __linux__ and __OpenBSD__. With the components, we are also relying on the output of uname(1). Additionally, if the os.mk is not present, make gives the output $ make Makefile:5: os.mk: No such file or directory make: *** No rule to make target 'os.mk'. Stop. This could easily be fixed by providing some sort of meta-rule for this file, however, it indicates the problem we have here, and this entire statefulness will heavily complicate packaging of this tool and makes the build process much more complex than it actually has to be.
2018-05-01 18:10:39 +02:00
# compiler and linker
CC = cc
Copy Permalink