em/slstatus
1
0
Fork 0
Code Releases Activity
35219d39ca
slstatus/components/run_command.c

29 lines
446 B
C
Raw Normal View History

Added LICENSE statements to all source files
2017-09-17 17:45:03 +02:00
/* See LICENSE file for copyright and license details. */
Format error messages properly Make use of strerror(errno) and format all errors equally: function ['parameters']: error message
2018-03-28 19:46:27 +02:00
#include <errno.h>
Split into multiple files For multiple reasons the program is now split: - Make future porting to OpenBSD easier - Assign header includes to individiual functions - Make future program extensions easier - Recompile only changed parts
2017-09-17 16:18:17 +02:00
#include <stdio.h>
#include <string.h>
Move components into dedicated subdirectory This brings us a lot more tidiness.
2017-09-24 15:33:01 +02:00
#include "../util.h"
Split into multiple files For multiple reasons the program is now split: - Make future porting to OpenBSD easier - Assign header includes to individiual functions - Make future program extensions easier - Recompile only changed parts
2017-09-17 16:18:17 +02:00
const char *
run_command(const char *cmd)
{
char *p;
FILE *fp;
run_command: Clean up
2018-05-02 08:29:36 +02:00
if (!(fp = popen(cmd, "r"))) {
Add warn() and die() Given slstatus is a tool that runs in the background, most likely run from .xinitrc, it's important to prepend the name of the tool to error messages so it becomes clear where the error is coming from. To make this much more consistent, this commit adds warn() and die() utility functions consistent with other suckless projects and adapts all calls to fprintf(stderr, *) to the warn() and die() functions, greatly increasing the readability of the code.
2018-05-18 10:59:05 +02:00
warn("popen '%s':", cmd);
Split into multiple files For multiple reasons the program is now split: - Make future porting to OpenBSD easier - Assign header includes to individiual functions - Make future program extensions easier - Recompile only changed parts
2017-09-17 16:18:17 +02:00
return NULL;
}
p = fgets(buf, sizeof(buf) - 1, fp);
pclose(fp);
Fix coding style - Use block for single statement ifs - Keep lines to reasonable length (current debate as to reasonable) - When functions return -1 for error test against 0 not -1 - Do not indent cases another level - Do not test against NULL and 0 explicitly - Use tabs for indentation, use spaces for alignment
2018-05-06 22:28:56 +02:00
if (!p) {
Split into multiple files For multiple reasons the program is now split: - Make future porting to OpenBSD easier - Assign header includes to individiual functions - Make future program extensions easier - Recompile only changed parts
2017-09-17 16:18:17 +02:00
return NULL;
Fix coding style - Use block for single statement ifs - Keep lines to reasonable length (current debate as to reasonable) - When functions return -1 for error test against 0 not -1 - Do not indent cases another level - Do not test against NULL and 0 explicitly - Use tabs for indentation, use spaces for alignment
2018-05-06 22:28:56 +02:00
}
if ((p = strrchr(buf, '\n'))) {
Split into multiple files For multiple reasons the program is now split: - Make future porting to OpenBSD easier - Assign header includes to individiual functions - Make future program extensions easier - Recompile only changed parts
2017-09-17 16:18:17 +02:00
p[0] = '\0';
Fix coding style - Use block for single statement ifs - Keep lines to reasonable length (current debate as to reasonable) - When functions return -1 for error test against 0 not -1 - Do not indent cases another level - Do not test against NULL and 0 explicitly - Use tabs for indentation, use spaces for alignment
2018-05-06 22:28:56 +02:00
}
Split into multiple files For multiple reasons the program is now split: - Make future porting to OpenBSD easier - Assign header includes to individiual functions - Make future program extensions easier - Recompile only changed parts
2017-09-17 16:18:17 +02:00
return buf[0] ? buf : NULL;
}
Copy Permalink