em/dwm
1
0
Fork 0
Code Releases Activity

do not call signal-unsafe function inside sighanlder

Browse Source 
die() calls vprintf, fputc and exit; none of these are
async-signal-safe, see `man 7 signal-safety`.
This commit is contained in:
NRK
2022-07-14 07:26:40 +06:00
committed by Hiltjo Posthuma
parent 9bffa845fa
commit 6613d9f9a1
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
dwm.c
View File

@@ -1541,6 +1541,8 @@ setup(void)
Atom utf8string; Atom utf8string;
/* clean up any zombies immediately */ /* clean up any zombies immediately */
if (signal(SIGCHLD, sigchld) == SIG_ERR)
die("can't install SIGCHLD handler:");
sigchld(0); sigchld(0);
/* init screen */ /* init screen */
@@ -1638,8 +1640,6 @@ showhide(Client *c)
void void
sigchld(int unused) sigchld(int unused)
{ {
if (signal(SIGCHLD, sigchld) == SIG_ERR)
die("can't install SIGCHLD handler:");
while (0 < waitpid(-1, NULL, WNOHANG)); while (0 < waitpid(-1, NULL, WNOHANG));
} }